Polish POM files #5104
Open
Polish POM files #5104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use Maven transitivity to obtain test dependencies from spring-ai-test module - Use Maven transitivity to obtain testcontainers dependency - Add missing test scopes - Use Oracle JDBC driver version managed by Spring Boot - Use variable for Redis Testcontainers version - Add missing license headers Signed-off-by: Nicolas Krier <7557886+nicolaskrier@users.noreply.github.com>
nicolaskrier
force-pushed
the
polish-pom-files
branch
from
4c925d4 to
5bd2607
Compare
nicolaskrier
commented
Dec 16, 2025
| <exclusion> | ||
| <groupId>com.vaadin.external.google</groupId> | ||
| <artifactId>android-json</artifactId> | ||
| <groupId>org.skyscreamer</groupId> |
Contributor
Author
There was a problem hiding this comment.
- I think this exclusion here is easiest to understand.
- Modules using jsonassert also require android-json. That is why I had to add jsonassert dependency to some modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.