Rest controller#16
Open
GrimReaper73 wants to merge 2 commits intospringframeworkguru:rest-controllerfrom
Open
Conversation
into the mapper. This allows a single place for the URL to be set, thus simplifying the service implementation. In my point of view, the setting of the URL is more a mappers function than the service. Hopefully you agree.
…ing5-mvc-rest into rest-controller
Author
|
Forgot to mention, it also allows you to test the URL value. See guru.springfamework.api.v1.mapper.VendorMapperTest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added vendor and moved the URL setting from the service implementation
into the mapper. This allows a single place for the URL to be set, thus
simplifying the service implementation. In my point of view, the setting
of the URL is more a mappers function than the service. Hopefully you
agree.