Open
Conversation
ppodgorsek
suggested changes
Dec 21, 2018
ppodgorsek
left a comment
ppodgorsek
left a comment
There was a problem hiding this comment.
In addition to the inline comments, was there a reason to rename the context file?
| *.iml | ||
| *.ipr | ||
| *.iws | ||
| */*.iml |
There was a problem hiding this comment.
Already covered by *.iml
Suggested change
| */*.iml |
| *.ipr | ||
| *.iws | ||
| */*.iml | ||
| */*.iws |
There was a problem hiding this comment.
Already covered by *.iws
Suggested change
| */*.iws |
| *.iws | ||
| */*.iml | ||
| */*.iws | ||
| */*.ipr |
There was a problem hiding this comment.
Already covered by *.ipr
Suggested change
| */*.ipr |
|
|
||
| @RunWith(SpringJUnit4ClassRunner.class) | ||
| @ContextConfiguration | ||
| @ContextConfiguration({"classpath:com/github/springtestdbunit/sample/service/applicationContext.xml"}) |
There was a problem hiding this comment.
Why does the existing configuration need to be changed?
Suggested change
| @ContextConfiguration({"classpath:com/github/springtestdbunit/sample/service/applicationContext.xml"}) | |
| @ContextConfiguration |
| assertEquals(1, personList.size()); | ||
| assertEquals("wu", personList.get(0).getLastName()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please also test testRemove() to be consistent with the above test class.
| public class XlsDataSetLoader extends AbstractDataSetLoader { | ||
|
|
||
| @Override | ||
| protected IDataSet createDataSet(Resource resource) throws Exception { |
There was a problem hiding this comment.
Suggested change
| protected IDataSet createDataSet(Resource resource) throws Exception { | |
| protected IDataSet createDataSet(final Resource resource) throws Exception { |
| import java.io.InputStream; | ||
|
|
||
| /** | ||
| * Created by yangjianzhou on 17-11-18. |
There was a problem hiding this comment.
Suggested change
| * Created by yangjianzhou on 17-11-18. | |
| * {@link com.github.springtestdbunit.dataset.DataSetLoader DataSetLoader} for Excel (.xls) files. | |
| * | |
| * Created by yangjianzhou on 17-11-18. |
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| @RunWith(SpringJUnit4ClassRunner.class) | ||
| @ContextConfiguration({"classpath:com/github/springtestdbunit/sample/service/applicationContext.xml"}) |
There was a problem hiding this comment.
Suggested change
| @ContextConfiguration({"classpath:com/github/springtestdbunit/sample/service/applicationContext.xml"}) | |
| @ContextConfiguration |
|
XLS support added in a maintained repository: https://github.com/ppodgorsek/spring-test-dbunit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 . update .gitignore and ignore .iml . ipr and so on
2 . add xlsDataSetLoader and test it where XlsDataSetLoaderTest