Conversation
… pin via binding) Design for making owner_id the base58 Solana wallet address, accepted alongside legacy X25519-hex, without changing the Noise-KK X25519 data plane. Decouples owner_id's triple role (routing label / KK pin / agent pin) — the agent learns the X25519 transport key from a wallet-signed binding (B1.2) carried in an opaque SignalMsg field the blind relay forwards. Both-forms acceptance, re-pair to upgrade. For review before implementation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design spec for B1.4 — the first slice that touches the live relay + agent. For your review before I write any code.
Goal: make
owner_idthe base58 Solana wallet address, accepted alongside legacy X25519-hex, without changing the Noise-KK X25519 transport or its vectors.The core finding
owner_idhas a triple role today, all the same string (the owner's X25519 pub hex): relay routing label, the Noise-KK key the agent pins, and the agent's paired-owner entry. To make it a wallet address, the KK pin must be decoupled from the routing label — the agent learns the X25519 transport key from a wallet-signed binding (B1.2) instead of hex-decodingowner_id.Key design decisions (please sanity-check)
Bindingfield onSignalMsg— the relay re-marshals a typed struct (drops unknown fields), so it needs that one field to forward it; it never reads it (stays blind). The KK responder needs the initiator static before msg0, and the offer is the only client→agent message that precedes Noise — so the offer is the right carrier.owner_idmatching^[0-9a-f]{64}$→ legacy path, byte-identical to today (no binding). Otherwise → wallet path (base58, binding required, no silent fallback).authsig (over the SAS nonce) proves wallet control when first pinning a base58 owner.Open questions I'd like your call on
auth-over-nonce into B1.4, or split to a follow-up once attach-by-wallet works e2e?owner_idindefinitely for legacy identities (my rec), or nudge a re-key?owner.json(my rec) vs re-sign per attach.Note
Deploying the new
mir-signal(the one-lineBindingfield) is live-infra — your hand, health-gated redeploy as before.No code in this PR — spec only. Approve / redirect and I'll write the implementation plan + B1.4.0.
🤖 Generated with Claude Code