[codex] Fix setup.sh overwriting Claude Code settings#14
Draft
happy-pills-dev wants to merge 1 commit into
Draft
[codex] Fix setup.sh overwriting Claude Code settings#14happy-pills-dev wants to merge 1 commit into
happy-pills-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes the Claude Code setup path in
setup.shso it no longer overwrites an existing~/.claude/settings.json.The installer now:
settings.jsonwhen it does not existmcpServers.openbrainmcpServersshapeWhy
Option 3 previously used
cat > "$CONFIG", replacing the full Claude Code settings file and potentially deleting user permissions, existing MCP servers, or other configuration. That matches the data-loss behavior reported in #13.Validation
bash -n setup.shCloses #13