Skip to content

fix multiple workspace warnings#89

Open
Bananeweizen wants to merge 3 commits into
ssi-schaefer:masterfrom
Bananeweizen:cleanup
Open

fix multiple workspace warnings#89
Bananeweizen wants to merge 3 commits into
ssi-schaefer:masterfrom
Bananeweizen:cleanup

Conversation

@Bananeweizen

Copy link
Copy Markdown
Contributor

All remaining workspace warnings are now coupled to bad versioning of dependencies (e.g. Xtend last() method, deprecated PDE methods etc.)

While they are in the grammar definition, they are not part of the
generated code and parser. So they can be deleted.
@Bananeweizen

Copy link
Copy Markdown
Contributor Author

@haubi can you please review this one? it doesn't add any version restrictions or similar, but just removes warnings without functional changes

@haubi

haubi commented Dec 20, 2024

Copy link
Copy Markdown
Member

Regarding the Xtext warnings, I've added a comment for why they are there - the difference is in the Xtext generated code.
The other 2 commits I've picked into master, which now requires Eclipse 2022-09 and Java 17, with the idea in mind to create the 0.8.0 release (maybe in January).
For Eclipse 2024-09 and Java 21 I've created an eclipse-2024-09 branch for now, should become the 0.9.0 release afterwards.

IIRC, we have talked about declaring dependency versions.
Although I have some ideas about it: What exactly do you mean?
Is there any tooling that helps in declaring (and updating) the dependency versions?

@haubi

haubi commented Oct 27, 2025

Copy link
Copy Markdown
Member

@Bananeweizen Now I have applied some housekeeping to master branch, also with your concerns in mind:

  • The dependencey versions now are set to require Eclipse 2024-09 as minimum version, as it turns out that it's relevant API/ABI is compatible with 2025-09 still.
  • Only those warnings remain around the enum aliases, like Enum literal 'GB' has already been defined with literal 'G'., as I still don't have a good but simple idea on how to fix them.

Would you mind to have a look on current master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants