Skip to content

test: Update Trino versions to match SDP 26.3 #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbernauer merged 2 commits into from
Feb 17, 2026
Merged

test: Update Trino versions to match SDP 26.3 #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e25e65a
test: Update Trino versions to match nightly SDP version
sbernauer Feb 17, 2026
687e5ad
Merge branch 'main' into test/bump-trino
sbernauer Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/templates/kuttl/client-spooling/10-install-trino.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ metadata:
name: trino-client-spooling
spec:
image:
{% if test_scenario['values']['trino-client-spooling'].find(",") > 0 %}
custom: "{{ test_scenario['values']['trino-client-spooling'].split(',')[1] }}"
productVersion: "{{ test_scenario['values']['trino-client-spooling'].split(',')[0] }}"
{% if test_scenario['values']['trino'].find(",") > 0 %}
custom: "{{ test_scenario['values']['trino'].split(',')[1] }}"
productVersion: "{{ test_scenario['values']['trino'].split(',')[0] }}"
{% else %}
productVersion: "{{ test_scenario['values']['trino-client-spooling'] }}"
productVersion: "{{ test_scenario['values']['trino'] }}"
{% endif %}
pullPolicy: IfNotPresent
clusterConfig:
Expand Down
2 changes: 1 addition & 1 deletion tests/templates/kuttl/client-spooling/30-test-queries.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ spec:
containers:
- name: test-queries
# image: oci.stackable.tech/sdp/trino-cli:476-stackable0.0.0-dev
image: oci.stackable.tech/sdp/trino-cli:{{ test_scenario['values']['trino-client-spooling'] }}-stackable0.0.0-dev
image: oci.stackable.tech/sdp/trino-cli:{{ test_scenario['values']['trino'] }}-stackable0.0.0-dev
command:
- /bin/bash
- -x
Expand Down
17 changes: 5 additions & 12 deletions tests/test-definition.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,17 @@ dimensions:
- name: trino-lb
values:
- oci.stackable.tech/stackable/trino-lb:dev
# - oci.stackable.tech/stackable/trino-lb:0.5.0
# - foo:bar
- name: trino
values:
- "451"
# - "470" # Reduce test count
- "476"
- "477"
- "479"
# To use a custom image, add a comma and the full name after the product version
# - 470,oci.stackable.tech/sdp/trino:470-stackable0.0.0-dev
# However, watch out, you need to tweak the trino-cli image
- name: trino-latest
values:
- "470"
# As not all Trino versions support client spooling, we have an extra dimension
- name: trino-client-spooling
values:
# According to https://docs.stackable.tech/home/nightly/trino/usage-guide/client-spooling-protocol/
# > The client spooling protocol was introduced in Trino 466 but it only works reliably starting with Trino 476.
- "476"
- "479"
- name: trino-lb-https
values:
- "true"
Expand All @@ -43,7 +36,7 @@ tests:
- name: client-spooling
dimensions:
- trino-lb
- trino-client-spooling
- trino
- client-spooling-retrieval-mode

# TODOS
Expand Down
Loading