feat(all): Upgrade Node.js and drop EoLs support #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseLion
force-pushed
the
feat/upgrade-nodejs
branch
from
b5cb101 to
6928f25
Compare
JoseLion
requested review from
ACR1209,
SbsCruz,
fonsiher and
kdquistanchala
SbsCruz
reviewed
Nov 27, 2025
| "name": "@examples/mocha", | ||
| "private": true, | ||
| "scripts": { | ||
| "check": "yarn compile && yarn test --forbid-only", |
There was a problem hiding this comment.
qq, what does the "--forbid-only" flag do?
Contributor
Author
There was a problem hiding this comment.
@SbsCruz it causes the tests to fail if there's any it.only(..) tests. The .only method helps a lot during development, but it can inadvertently exclude tests on CI. That's why we add it to the check script 🙂
SbsCruz
reviewed
Nov 27, 2025
| import { RootHookObject } from "mocha"; | ||
|
|
||
| export function mochaHooks(): RootHookObject { | ||
| export function mochaHooks(): Mocha.RootHookObject { |
There was a problem hiding this comment.
i see we are calling this object from Mocha now and not importing it, but why was the import deleted?
Contributor
Author
There was a problem hiding this comment.
@SbsCruz remember we're not calling calling an object here, it's just the type definition. We don't need to import it because mocha exposes the whole Mocha namespace (types) for us to use 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the Node.js version:
Currenton .nvmrc for development.Maintenance LTS,Active LTS, andCurrent.Additionally, this PR adds some minor changes/improvements:
rimrafas a dev dependency to create a cross-platformcleanscriptcheckscript.