Skip to content

Conversation

@elelaysh
Copy link
Contributor

changes to stackhpc-multinode.yml:

  • new github_user_ssh_keys input (defaults to true)
  • previous input ssh_key is still here and overrides github_user_ssh_keys

@elelaysh elelaysh requested a review from a team as a code owner December 15, 2025 09:22
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@elelaysh
Copy link
Contributor Author

Multiline input is not supported in github actions, see
this discussion for instance.

So the ssh_key input still only supports a single key. If we want to extend this, we could check if the first character is a square bracket ([) and assume the input is already a json-encoded array in this case.

Should I implement that?

@elelaysh
Copy link
Contributor Author

Co-authored-by: Alex Welsh <112560678+Alex-Welsh@users.noreply.github.com>
@Alex-Welsh Alex-Welsh merged commit 7fa6ac4 into stackhpc/2025.1 Dec 18, 2025
21 checks passed
@Alex-Welsh Alex-Welsh deleted the feat/workflow-multinode-github-user branch December 18, 2025 09:50
@elelaysh
Copy link
Contributor Author

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants