Skip to content

fix(go): nullable additionalProperties produces wrong map value type #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PatrickKoss wants to merge 4 commits into from
Closed

fix(go): nullable additionalProperties produces wrong map value type #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f329ad
fix nullable additional properties
PatrickKoss May 7, 2026
a08efcf
fix linting
PatrickKoss May 7, 2026
415fc53
fix pipeline download
PatrickKoss May 7, 2026
4d5db4d
fix linting
PatrickKoss May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions languages/golang/compat-layer/templates/field_type.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{{!
Renders the Go type for a property, accounting for nullable additionalProperties.
Upstream Go codegen ignores `nullable: true` inside additionalProperties when
computing the map value type, producing `map[string]string` instead of
`map[string]*string`. This partial restores the missing `*` on the map value
when the additionalProperties schema is nullable AND the schema is a typed map
(not a free-form object, where dataType is already `map[string]interface{}`
and pointer-wrapping the value would produce `map[string]*interface{}`).
Otherwise it emits the upstream-computed dataType unchanged.
}}{{#isMap}}{{^isFreeFormObject}}{{#additionalProperties.isNullable}}map[string]*{{{additionalProperties.dataType}}}{{/additionalProperties.isNullable}}{{^additionalProperties.isNullable}}{{{dataType}}}{{/additionalProperties.isNullable}}{{/isFreeFormObject}}{{#isFreeFormObject}}{{{dataType}}}{{/isFreeFormObject}}{{/isMap}}{{^isMap}}{{{dataType}}}{{/isMap}}
6 changes: 3 additions & 3 deletions languages/golang/compat-layer/templates/model_simple.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,11 +633,11 @@ func set{{classname}}{{getter}}AttributeType(arg *{{classname}}{{getter}}Attribu
{{^isArray}}
// isContainer
// Deprecated: Will be removed after 2026-09-30. Move to the packages generated for each available API version instead
type {{classname}}{{getter}}AttributeType = *{{dataType}}
type {{classname}}{{getter}}AttributeType = *{{>field_type}}
// Deprecated: Will be removed after 2026-09-30. Move to the packages generated for each available API version instead
type {{classname}}{{getter}}ArgType = {{#isNullable}}*{{/isNullable}}{{dataType}}
type {{classname}}{{getter}}ArgType = {{#isNullable}}*{{/isNullable}}{{>field_type}}
// Deprecated: Will be removed after 2026-09-30. Move to the packages generated for each available API version instead
type {{classname}}{{getter}}RetType = {{#isNullable}}*{{/isNullable}}{{dataType}}
type {{classname}}{{getter}}RetType = {{#isNullable}}*{{/isNullable}}{{>field_type}}
// Deprecated: Will be removed after 2026-09-30. Move to the packages generated for each available API version instead
func get{{classname}}{{getter}}AttributeTypeOk(arg {{classname}}{{getter}}AttributeType) (ret {{classname}}{{getter}}RetType, ok bool) {
if arg == nil {
Expand Down
10 changes: 10 additions & 0 deletions languages/golang/templates/field_type.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{{!
Renders the Go type for a property, accounting for nullable additionalProperties.
Upstream Go codegen ignores `nullable: true` inside additionalProperties when
computing the map value type, producing `map[string]string` instead of
`map[string]*string`. This partial restores the missing `*` on the map value
when the additionalProperties schema is nullable AND the schema is a typed map
(not a free-form object, where dataType is already `map[string]interface{}`
and pointer-wrapping the value would produce `map[string]*interface{}`).
Otherwise it emits the upstream-computed dataType unchanged.
}}{{#isMap}}{{^isFreeFormObject}}{{#additionalProperties.isNullable}}map[string]*{{{additionalProperties.dataType}}}{{/additionalProperties.isNullable}}{{^additionalProperties.isNullable}}{{{dataType}}}{{/additionalProperties.isNullable}}{{/isFreeFormObject}}{{#isFreeFormObject}}{{{dataType}}}{{/isFreeFormObject}}{{/isMap}}{{^isMap}}{{{dataType}}}{{/isMap}}
11 changes: 11 additions & 0 deletions languages/golang/templates/field_type_base.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{{!
Renders the Go base (unwrapped) type for a property, accounting for nullable
additionalProperties. Used in getter/setter signatures where upstream emits
the vendor base type. For typed maps whose additionalProperties schema is
nullable, upstream ignores nullable=true and produces map[string]string
instead of map[string]*string. This partial restores the missing pointer in
that case. Free-form objects (`additionalProperties: true` -> dataType
`map[string]interface{}`) are excluded so we don't produce
`map[string]*interface{}`. Otherwise the upstream base type is emitted
unchanged.
}}{{#isMap}}{{^isFreeFormObject}}{{#additionalProperties.isNullable}}map[string]*{{{additionalProperties.dataType}}}{{/additionalProperties.isNullable}}{{^additionalProperties.isNullable}}{{vendorExtensions.x-go-base-type}}{{/additionalProperties.isNullable}}{{/isFreeFormObject}}{{#isFreeFormObject}}{{vendorExtensions.x-go-base-type}}{{/isFreeFormObject}}{{/isMap}}{{^isMap}}{{vendorExtensions.x-go-base-type}}{{/isMap}}
Loading
Loading