Feature/upgrade to golangci lint v2#1443
Open
Manuelvaas wants to merge 4 commits intomainfrom
Open
Conversation
marceljk
reviewed
May 5, 2026
Comment on lines
-3214
to
-3227
| resource.TestCheckResourceAttrPair( | ||
| "stackit_security_group_rule.security_group_rule", "project_id", | ||
| "stackit_security_group.security_group", "project_id", | ||
| ), | ||
| resource.TestCheckResourceAttrPair( | ||
| "stackit_security_group_rule.security_group_rule", "security_group_id", | ||
| "stackit_security_group.security_group", "security_group_id", | ||
| ), | ||
| resource.TestCheckResourceAttrPair( | ||
| "stackit_security_group_rule.security_group_rule_remote_security_group", "remote_security_group_id", | ||
| "stackit_security_group.security_group_remote", "security_group_id", | ||
| ), | ||
| resource.TestCheckResourceAttrSet("stackit_security_group_rule.security_group_rule", "security_group_rule_id"), | ||
| resource.TestCheckResourceAttr("stackit_security_group_rule.security_group_rule", "direction", testutil.ConvertConfigVariable(testConfigSecurityGroupsVarsMax["direction"])), |
Contributor
There was a problem hiding this comment.
I think here was just a copy paste issue, because these checks should check the remote security group regarding the comment. So instead of removing the checks, they should be adjusted.
replace "stackit_security_group_rule.security_group_rule" with "stackit_security_group_rule.security_group_rule_remote_security_group" in these checks
Comment on lines
3369
to
3370
| ), | ||
| resource.TestCheckResourceAttrSet("data.stackit_security_group_rule.security_group_rule", "security_group_rule_id"), | ||
| resource.TestCheckResourceAttr("data.stackit_security_group_rule.security_group_rule", "direction", testutil.ConvertConfigVariable(testConfigSecurityGroupsVarsMax["direction"])), | ||
| ), |
Contributor
There was a problem hiding this comment.
same here, looks just like a copy paste issue and the wrong data source is here referenced
Comment on lines
-3486
to
-3499
| resource.TestCheckResourceAttrPair( | ||
| "stackit_security_group_rule.security_group_rule", "project_id", | ||
| "stackit_security_group.security_group", "project_id", | ||
| ), | ||
| resource.TestCheckResourceAttrPair( | ||
| "stackit_security_group_rule.security_group_rule", "security_group_id", | ||
| "stackit_security_group.security_group", "security_group_id", | ||
| ), | ||
| resource.TestCheckResourceAttrPair( | ||
| "stackit_security_group_rule.security_group_rule_remote_security_group", "remote_security_group_id", | ||
| "stackit_security_group.security_group_remote", "security_group_id", | ||
| ), | ||
| resource.TestCheckResourceAttrSet("stackit_security_group_rule.security_group_rule", "security_group_rule_id"), | ||
| resource.TestCheckResourceAttr("stackit_security_group_rule.security_group_rule", "direction", testutil.ConvertConfigVariable(testConfigSecurityGroupsVarsMaxUpdated()["direction"])), |
Co-authored-by: Marcel Jacek <72880145+marceljk@users.noreply.github.com>
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to #1277 and STACKITTPR-253
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)