feat(skills): add skills page with list, install, uninstall and build under feature flag#1878
Open
feat(skills): add skills page with list, install, uninstall and build under feature flag#1878
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Skills feature (behind the experimental skills flag) including a new /skills route and UI to list, install, build, and uninstall skills via the /api/v1beta/skills endpoints.
Changes:
- Introduces the
skillsexperimental feature flag and wires it into settings + top navigation. - Adds a new
/skillsroute and page UI (card grid with search, plus install/build/uninstall dialogs). - Adds React Query mutation hooks + MSW fixtures and Vitest coverage for the new skills flows.
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/feature-flags.ts | Adds SKILLS feature flag key. |
| main/src/feature-flags/flags.ts | Registers the skills flag as experimental/off-by-default. |
| renderer/src/common/hooks/use-experimental-features.tsx | Adds name/description for the skills flag in the experimental features UI. |
| renderer/src/common/components/layout/top-nav/index.tsx | Shows “Skills” nav link only when the flag is enabled. |
| renderer/src/routes/skills.tsx | Adds the /skills route with loader prefetch for skills list. |
| renderer/src/route-tree.gen.ts | Generated route tree updated to include /skills. |
| renderer/src/common/components/link-view-transition.tsx | Adds /skills to ordered routes list for transitions. |
| renderer/src/features/skills/components/skills-page.tsx | Page that fetches and renders skills list, plus install/build dialogs. |
| renderer/src/features/skills/components/grid-cards-skills.tsx | Renders skills as a responsive card grid. |
| renderer/src/features/skills/components/card-skill.tsx | Skill card UI + uninstall action. |
| renderer/src/features/skills/components/dialog-install-skill.tsx | Install flow UI (scope/project root picker, client dropdown). |
| renderer/src/features/skills/components/dialog-build-skill.tsx | Build flow UI + “Install now” toast action. |
| renderer/src/features/skills/components/dialog-uninstall-skill.tsx | Uninstall confirmation dialog. |
| renderer/src/features/skills/hooks/use-mutation-*.ts | React Query mutation hooks for install/build/uninstall. |
| renderer/src/common/mocks/fixtures/skills*/** | MSW AutoAPIMock fixtures for skills endpoints. |
| renderer/src/common/mocks/electronAPI.ts | Adds selectFolder mock for dialog folder pickers. |
| renderer/src/features/skills/**/tests/* | Adds component + hook tests for the new skills feature. |
renderer/src/features/skills/components/dialog-uninstall-skill.tsx
Outdated
Show resolved
Hide resolved
renderer/src/features/skills/components/dialog-uninstall-skill.tsx
Outdated
Show resolved
Hide resolved
renderer/src/features/skills/components/dialog-install-skill.tsx
Outdated
Show resolved
Hide resolved
renderer/src/features/skills/components/dialog-install-skill.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new Skills page behind the
skillsexperimental feature flag that exposes basic CRUD operations against the/api/v1beta/skillsendpoints.What's included:
skillsflag (experimental, off by default); opt-in via Settings → Experimental featuresproject_root; client dropdown populated from/api/v1beta/discovery/clients(installed clients only, sorted alphabetically)Kapture.2026-03-30.at.19.26.21.mp4