Skip to content

feat(skills): add skills page with list, install, uninstall and build under feature flag#1878

Open
samuv wants to merge 4 commits intomainfrom
skills-poc
Open

feat(skills): add skills page with list, install, uninstall and build under feature flag#1878
samuv wants to merge 4 commits intomainfrom
skills-poc

Conversation

@samuv
Copy link
Copy Markdown
Collaborator

@samuv samuv commented Mar 30, 2026

Adds a new Skills page behind the skills experimental feature flag that exposes basic CRUD operations against the /api/v1beta/skills endpoints.

What's included:

  • Feature flagskills flag (experimental, off by default); opt-in via Settings → Experimental features
  • Skills page — lists installed skills in a card grid with search/filter; accessible from the top nav when the flag is enabled
  • Install — dialog to install a skill by OCI reference; supports user/project scope; project scope requires a folder picker for project_root; client dropdown populated from /api/v1beta/discovery/clients (installed clients only, sorted alphabetically)
  • Build — dialog to build a skill from a local directory; native folder picker for path; on success shows a toast with an "Install now" action that pre-fills the install dialog
  • Uninstall — confirmation dialog per card
Kapture.2026-03-30.at.19.26.21.mp4

@samuv samuv self-assigned this Mar 30, 2026
Copilot AI review requested due to automatic review settings March 30, 2026 17:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Skills feature (behind the experimental skills flag) including a new /skills route and UI to list, install, build, and uninstall skills via the /api/v1beta/skills endpoints.

Changes:

  • Introduces the skills experimental feature flag and wires it into settings + top navigation.
  • Adds a new /skills route and page UI (card grid with search, plus install/build/uninstall dialogs).
  • Adds React Query mutation hooks + MSW fixtures and Vitest coverage for the new skills flows.

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
utils/feature-flags.ts Adds SKILLS feature flag key.
main/src/feature-flags/flags.ts Registers the skills flag as experimental/off-by-default.
renderer/src/common/hooks/use-experimental-features.tsx Adds name/description for the skills flag in the experimental features UI.
renderer/src/common/components/layout/top-nav/index.tsx Shows “Skills” nav link only when the flag is enabled.
renderer/src/routes/skills.tsx Adds the /skills route with loader prefetch for skills list.
renderer/src/route-tree.gen.ts Generated route tree updated to include /skills.
renderer/src/common/components/link-view-transition.tsx Adds /skills to ordered routes list for transitions.
renderer/src/features/skills/components/skills-page.tsx Page that fetches and renders skills list, plus install/build dialogs.
renderer/src/features/skills/components/grid-cards-skills.tsx Renders skills as a responsive card grid.
renderer/src/features/skills/components/card-skill.tsx Skill card UI + uninstall action.
renderer/src/features/skills/components/dialog-install-skill.tsx Install flow UI (scope/project root picker, client dropdown).
renderer/src/features/skills/components/dialog-build-skill.tsx Build flow UI + “Install now” toast action.
renderer/src/features/skills/components/dialog-uninstall-skill.tsx Uninstall confirmation dialog.
renderer/src/features/skills/hooks/use-mutation-*.ts React Query mutation hooks for install/build/uninstall.
renderer/src/common/mocks/fixtures/skills*/** MSW AutoAPIMock fixtures for skills endpoints.
renderer/src/common/mocks/electronAPI.ts Adds selectFolder mock for dialog folder pickers.
renderer/src/features/skills/**/tests/* Adds component + hook tests for the new skills feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants