Add quality gates workflow and local gate script

.clang-format

@@ -1,6 +1,8 @@
 ---
 Language:               Cpp
 Standard:               Cpp11
+PointerAlignment:       Left
+ReferenceAlignment:     Left
 BasedOnStyle:           Google
 ColumnLimit:            128
 ---

.clang-tidy

@@ -1,20 +1,5 @@
 ---
-Checks:          'clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-alpha*,*,-clang-analyzer-core.UndefinedBinaryOperatorResult,-clang-analyzer-core.uninitialized.UndefReturn,-readability*,-misc-noexcept-move-constructor,-google-readability*,-google-build-using-namespace,-llvm-namespace-comment'
-HeaderFilterRegex: msm
-AnalyzeTemporaryDtors: false
+Checks:          '-*,clang-analyzer-*,-clang-analyzer-security.ArrayBound,-clang-analyzer-cplusplus.Move'
+HeaderFilterRegex: ""
 User:            git
-CheckOptions:
-  - key:             google-readability-braces-around-statements.ShortStatementLines
-    value:           '1'
-  - key:             google-readability-function-size.StatementThreshold
-    value:           '800'
-  - key:             google-readability-namespace-comments.ShortNamespaceLines
-    value:           '10'
-  - key:             google-readability-namespace-comments.SpacesBeforeComments
-    value:           '2'
-  - key:             misc-assert-side-effect.AssertMacros
-    value:           assert
-  - key:             misc-assert-side-effect.CheckFunctionCalls
-    value:           '0'
-...
-
+CheckOptions: []

.github/CONTRIBUTING.md

@@ -11,6 +11,7 @@ you contribute:
 4. Be sure your modifications include:
   * Don't break anything (`make`)
   * Proper unit/functional tests (`make test`)
+  * Full quality gates (`make quality`)
   * Documentation updates if required (`make doc`)
   * Regenerate preprocessed headers (`tools/pph.sh`)
   * Update/check style using (`make check`)

.github/workflows/quality_gates.yml

@@ -0,0 +1,36 @@
+name: quality_gates
+
+on:
+  push:
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  quality_gates:
+    name: Quality gates
+    runs-on: ubuntu-latest
+    env:
+      CXX: clang++
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y \
+            clang \
+            clang-format \
+            clang-tidy \
+            llvm \
+            cmake \
+            libboost-dev \
+            gcovr \
+            lcov \
+            ninja-build \
+            python3
+
+      - name: Run quality gates
+        run: |
+          ./scripts/quality_gates.sh

.gitignore

@@ -4,3 +4,5 @@
 *.out
 .vs
 .vscode
+.quality_gates/
+*.gcov

CMakeLists.txt

@@ -132,7 +132,7 @@ elseif (IS_COMPILER_OPTION_GCC_LIKE)
 
     if (NOT ${SML_USE_EXCEPTIONS})
       target_compile_options(sml INTERFACE
-        $<BUILD_INTERFACE:"-fno-exceptions"> # compiles without exception support
+        $<BUILD_INTERFACE:-fno-exceptions> # compiles without exception support
       )
     endif()
   endif()

Makefile

@@ -4,7 +4,7 @@
 # Distributed under the Boost Software License, Version 1.0.
 # (See accompanying file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
 #
-.PHONY: all doc clean test example
+.PHONY: all doc clean test example quality
 CXX?=clang++
 CXXSTD?=c++14
 
@@ -34,6 +34,9 @@ PLANTCXX:=$(subst -std=c++14,-std=c++17,$(CXXFLAGS))
 
 all: test example
 
+quality:
+	./scripts/quality_gates.sh
+
 check: style
 
 test: $(patsubst %.cpp, %.out, $(wildcard test/ft/*.cpp test/ft/errors/*.cpp test/ut/*.cpp test/unit/*.cpp))

README.md

@@ -119,6 +119,19 @@ int main() {
   cl /std:c++14 /Ox /W3 tcp_release.cpp
   ```
 
+#### Quality gates
+Use the new quality gate script for end-to-end checks:
+
+```sh
+./scripts/quality_gates.sh
+```
+
+Optional example:
+
+```sh
+./scripts/quality_gates.sh --skip-benchmarks --skip-sanitizers
+```
+
 <p align="center">
 <table>
   <tr>

benchmark/complex/CMakeLists.txt

@@ -11,7 +11,12 @@ if (IS_COMPILER_GCC_LIKE)
   set(CMAKE_CXX_STANDARD ${CURRENT_CXX_STANDARD})
 endif()
 
-add_executable(complex_euml2 euml2.cpp)
+if (EXISTS "${Boost_INCLUDE_DIRS}/boost/msm/front/euml2/euml2.hpp")
+  add_executable(complex_euml2 euml2.cpp)
+  target_link_libraries(complex_euml2 PRIVATE sml Boost::boost)
+else()
+  message(STATUS "Skipping complex_euml2 benchmark: boost/msm/front/euml2/euml2.hpp not found")
+endif()
 add_example(complex_sc benchmark_complex_sc sc.cpp)
 
 if (NOT IS_MSVC_2015)

benchmark/header/CMakeLists.txt

@@ -5,6 +5,11 @@
 # (See accompanying file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt)
 #
 add_example(header_euml benchmark_header_euml euml.cpp)
-add_executable(header_euml2 euml2.cpp)
+if (EXISTS "${Boost_INCLUDE_DIRS}/boost/msm/front/euml2/euml2.hpp")
+  add_executable(header_euml2 euml2.cpp)
+  target_link_libraries(header_euml2 PRIVATE sml Boost::boost)
+else()
+  message(STATUS "Skipping header_euml2 benchmark: boost/msm/front/euml2/euml2.hpp not found")
+endif()
 add_example(header_sc benchmark_header_sc sc.cpp)
 add_example(header_sml benchmark_header_sml sml.cpp)

example/dependency_injection.cpp

@@ -8,11 +8,11 @@
 // clang-format off
 #if __has_include(<boost/di.hpp>)
 // clang-format on
-#include <boost/sml.hpp>
 #include <boost/di.hpp>
+#include <boost/sml.hpp>
 #include <cassert>
-#include <typeinfo>
 #include <iostream>
+#include <typeinfo>
 
 namespace sml = boost::sml;
 namespace di = boost::di;

example/dispatch_table.cpp

@@ -18,7 +18,7 @@ struct runtime_event {
 };
 struct event1 {
   static constexpr auto id = 1;
-  event1(const runtime_event &) {}
+  event1(const runtime_event&) {}
 };
 struct event2 {
   static constexpr auto id = 2;

example/eval.cpp

@@ -16,7 +16,7 @@ struct e1 {};
 struct eval {
   auto operator()() const {
     const auto guard = [] { return true; };
-    const auto action = [](int &a) { ++a; };
+    const auto action = [](int& a) { ++a; };
 
     // clang-format off
     using namespace sml;
@@ -36,4 +36,3 @@ int main() {
   assert(3 == a);
   assert(sm.is(sml::X));
 }
-

include/boost/sml.hpp

@@ -23,8 +23,14 @@
   }                             \
   }                             \
   }
+#if defined(__clang__)
+#define __BOOST_SML_HAS_FEATURE(_Feature) __has_feature(_Feature)
+#else
+#define __BOOST_SML_HAS_FEATURE(_Feature) 0
+#endif
+
 #if defined(__SANITIZE_ADDRESS__) || defined(__SANITIZE_UNDEFINED__) || \
-    (defined(__has_feature) && (__has_feature(address_sanitizer) || __has_feature(undefined_behavior_sanitizer)))
+    __BOOST_SML_HAS_FEATURE(address_sanitizer) || __BOOST_SML_HAS_FEATURE(undefined_behavior_sanitizer)
 #define __BOOST_SML_SANITIZER_BUILD 1
 #else
 #define __BOOST_SML_SANITIZER_BUILD 0