Fix the group-wise control risk and KNN prediction indices#54
Merged
MatteoGiomi merged 2 commits intostatice:mainfrom Mar 27, 2026
Merged
Conversation
Align the prediction indices with the input indices in KNNInferencePredictor::predict.
MatteoGiomi
reviewed
Mar 27, 2026
Member
MatteoGiomi
left a comment
MatteoGiomi
left a comment
There was a problem hiding this comment.
Thanks for taking care of these bugs @itrajanovska! I left two small comments. Now I'll try to fix the build.
Use pd.testing.assert_index_equal instead of list comparison.
MatteoGiomi
approved these changes
Mar 27, 2026
Member
MatteoGiomi
left a comment
MatteoGiomi
left a comment
There was a problem hiding this comment.
Looks good to me! I'll merge it. Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we fix an issue in the group-wise inference risks, where we did not filter the targets for the current group only.
Additionally, we noticed an inconsistent index in the predictions of the KNN inference model, and therefore we aligned the indices of the predictions with those of the input samples. There is also a test for this fix.