fix(i18n): resolve add-budget-line aria-label from budget namespace on household items#1858
Merged
Merged
Conversation
…n household items PR #1844 switched the BudgetSection add-line button aria-label to t('budgetLineForm.addBudgetLineAriaLabel'), but t is namespace-switched to householdItems on household item pages where that key does not exist, so the accessible name rendered as the raw i18n key. Resolve it through the always-budget-namespaced tBudget instead. Fixes deterministic E2E failures on household-item-detail.spec.ts (all viewports) and budget/unit-pricing.spec.ts Scenario 3 observed in ad-hoc run 28934922175. Fixes #1857 Co-Authored-By: Claude frontend-developer (Haiku 4.5) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.13.0-beta.25 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
budgetLineForm.addBudgetLineAriaLabelbecause fix(i18n): translate milestones/budget/a11y strings and remove dead milestone panel cluster #1844 resolved it through the namespace-switchedt(bound tohouseholdItemsthere) instead of thebudgetnamespace where the key lives (en + de).tBudget(always bound tobudget).Root cause & evidence
Ad-hoc full E2E run 28934922175 on beta failed 4 shards (3, 4, 10, 14), all reducing to the accessible name "Add budget line" missing on household item pages:
household-items/household-item-detail.spec.ts:141— deterministic on desktop, tablet, and mobilebudget/unit-pricing.spec.ts:211(HI unit pricing with VAT) — deterministic on desktopWork-item pages were unaffected (
tresolves to thebudgetnamespace there), which is why only household-item tests failed. Tests are correct per the debugging protocol; this is a production accessibility regression.Test plan
🤖 Generated with Claude Code