Conversation
These changes are backwards-compatible, so it will first check S3 and fall back to on-disk if it cannot find the file. There's a new config option `s3_bucket_name`. We assume you have the region and AWS credentials configured in your enviornment. Also update dependencies to more modern versions.
These changes are backwards-compatible, so it will first check S3 and fall back to on-disk if it cannot find the file. There's a new config option `s3_bucket_name`. We assume you have the region and AWS credentials configured in your enviornment. Also update dependencies to more modern versions.
…r external service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow storing files in S3, instead of just on-disk
These changes are backwards-compatible, so it will first check S3 and fall back to on-disk if it cannot find the file.
There are two new config options:
s3_bucket_name: if this is set, we save new files here instead of on-disk. We assume you have the region and AWS credentials configured in your environmentdoc_root: this defaults to "/file", but if you can also set this to something like "http://.s3-website-us-west-2.amazonaws.com/" to use a S3 bucket configured for static website hostingTo migrate files from on-disk to S3, you'd take the numbered directories in "storage/docs/" and put them at the top level of the S3 bucket.
Also update dependencies to more modern versions.