Skip to content

fix: improve CLI paging, PCAP decoding, and SonarCloud docs#1

Merged
stephenlclarke merged 3 commits into
mainfrom
fix/cli-paging-pcap-sonar
Apr 11, 2026
Merged

fix: improve CLI paging, PCAP decoding, and SonarCloud docs#1
stephenlclarke merged 3 commits into
mainfrom
fix/cli-paging-pcap-sonar

Conversation

@stephenlclarke
Copy link
Copy Markdown
Owner

What changed

  • add bat-style output controls to fixdecoder, including --style, --plain, --number, --paging, --pager, --nowrap, and FIXDECODER_DEFAULT_ARGS
  • fix interactive CLI behaviour so the version banner only prints for --version, pager failures surface as real errors, live status is disabled while paging, and explicit --help / --version still work even when FIXDECODER_DEFAULT_ARGS is invalid
  • improve pcap2fix TCP reassembly by buffering out-of-order future segments, draining them when gaps are filled, resetting cleanly on overflow, and supporting IPv6 TCP payload extraction
  • improve order-summary tenor handling by deriving a trade date from TransactTime (60) when TradeDate (75) is absent
  • update README/help text for the new CLI features, restore the SonarCloud badge block, and align sonar-project.properties with the current fixdecoder_rs SonarCloud project
  • extend CLI and pcap2fix tests to cover the new paging/default-args behaviour and the TCP reassembly changes

Why it changed

Interactive terminal support and the pcap2fix decoder both had correctness gaps.

The CLI work had grown to support richer terminal presentation, but the pager path still treated broken pager execution as success, leaked live-status carriage-return updates into paged output, and allowed a bad FIXDECODER_DEFAULT_ARGS value to block explicit informational commands. In parallel, pcap2fix was still dropping out-of-order future TCP segments and only handling IPv4 flows, which meant valid FIX traffic could be missed during reassembly.

The SonarCloud docs/config changes address drift between the repository, the README badges, and the configured project key.

User impact

  • interactive fixdecoder usage is safer and more flexible in terminal and pager-driven workflows
  • pcap2fix can recover FIX messages from more realistic captures, including IPv6 and out-of-order TCP delivery
  • README/help output now documents the actual supported options and SonarCloud project links

Validation

  • cargo test --workspace
  • cargo clippy --workspace --all-targets -- -D warnings

@stephenlclarke stephenlclarke marked this pull request as ready for review April 11, 2026 15:04
@stephenlclarke stephenlclarke merged commit c49cb77 into main Apr 11, 2026
5 checks passed
@stephenlclarke stephenlclarke deleted the fix/cli-paging-pcap-sonar branch April 11, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant