fix: improve CLI paging, PCAP decoding, and SonarCloud docs#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
fixdecoder, including--style,--plain,--number,--paging,--pager,--nowrap, andFIXDECODER_DEFAULT_ARGS--version, pager failures surface as real errors, live status is disabled while paging, and explicit--help/--versionstill work even whenFIXDECODER_DEFAULT_ARGSis invalidpcap2fixTCP reassembly by buffering out-of-order future segments, draining them when gaps are filled, resetting cleanly on overflow, and supporting IPv6 TCP payload extractionTransactTime (60)whenTradeDate (75)is absentsonar-project.propertieswith the currentfixdecoder_rsSonarCloud projectpcap2fixtests to cover the new paging/default-args behaviour and the TCP reassembly changesWhy it changed
Interactive terminal support and the
pcap2fixdecoder both had correctness gaps.The CLI work had grown to support richer terminal presentation, but the pager path still treated broken pager execution as success, leaked live-status carriage-return updates into paged output, and allowed a bad
FIXDECODER_DEFAULT_ARGSvalue to block explicit informational commands. In parallel,pcap2fixwas still dropping out-of-order future TCP segments and only handling IPv4 flows, which meant valid FIX traffic could be missed during reassembly.The SonarCloud docs/config changes address drift between the repository, the README badges, and the configured project key.
User impact
fixdecoderusage is safer and more flexible in terminal and pager-driven workflowspcap2fixcan recover FIX messages from more realistic captures, including IPv6 and out-of-order TCP deliveryValidation
cargo test --workspacecargo clippy --workspace --all-targets -- -D warnings