Added PUBLIC_DIR argument to customise web directory#5
Open
Patabugen wants to merge 1 commit intosterner-stuff:1.xfrom
Open
Added PUBLIC_DIR argument to customise web directory#5Patabugen wants to merge 1 commit intosterner-stuff:1.xfrom
web directory#5Patabugen wants to merge 1 commit intosterner-stuff:1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to change the public-directory name from
webto anything they like by (optionally) adding aPUBLIC_PATHargument to the docker-compose file.I've applied the change to 7.4, 8.0 and 8.1 runtimes and it should be backwards compatible without a problem.
If users have published the
Dockerfileorsupervisord.confthey'll need to update both if they want to use the argument.Resolves: #4
Adds these docs to the readme:
Alternative Public Path
If your WordPress files are in a
web/directory in your repository then you're good to go - otherwise set the PUBLIC_DIR arg indocker-compose.yaml.