Skip to content

refactor + enhanced ui #26

Merged
stormyy00 merged 3 commits into
devfrom
feat/bin-detail-refactor
Jan 8, 2026
Merged

refactor + enhanced ui #26
stormyy00 merged 3 commits into
devfrom
feat/bin-detail-refactor

Conversation

@stormyy00
Copy link
Copy Markdown
Owner

…layout components

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
continote Ready Ready Preview, Comment Jan 8, 2026 3:31am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 8, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@stormyy00
Copy link
Copy Markdown
Owner Author

@coderabbitai review the pr

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 8, 2026

The author of this PR is on the CodeRabbit Free Plan. In order to use the Chat feature, please upgrade the PR author to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

const document = await this.documentsRepo.findById(documentId);

if (!document) {
if (!document || !document.filePath) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical bug: The code checks !document.filePath but findById() at line 323 doesn't select the filePath field (see documents.repository.ts lines 91-100). This will always evaluate to true, causing "Document not found" errors on valid documents.

// Fix in documents.repository.ts - add filePath to select
.select({
  id: documents.id,
  binId: documents.binId,
  filename: documents.filename,
  fileType: documents.fileType,
  fileSize: documents.fileSize,
  filePath: documents.filePath, // ADD THIS
  content: documents.content,
  createdAt: documents.createdAt,
  updatedAt: documents.updatedAt,
})

Spotted by Graphite Agent

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@stormyy00 stormyy00 merged commit edecb1e into dev Jan 8, 2026
7 of 10 checks passed
@stormyy00 stormyy00 deleted the feat/bin-detail-refactor branch January 8, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant