Skip to content

Conversation

@zastrowm
Copy link
Member

@zastrowm zastrowm commented Dec 8, 2025

Description

Two changes to unify the browser & node tests to have a more unified test suite:

  1. Update the integ tests to have a single loadFixture method that is usable from the browser & node tests
  2. Update shouldRunTests -> shouldSkipBedrockTests to match the naming of shouldSkipOpenAITests; so that we have the same style of "skipping" between the two

Follow-up PRs will:

  • Centralize the client creation for Bedrock & OpenAI, giving us a shared way of creating clients
  • Share more tests between the browser and node

Notes

Related Issues

Related to #225 - as part of #283, I realized we couldn't just have a vite import that really works for both

Documentation PR

Type of Change

Refactor

Testing

How have you tested the change?

  • I ran npm run check

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

 - Have a single `loadFixture` method usable from both the browser & node tests
 - Switch to skipping tests the same between Bedrock & OpenAI
@zastrowm zastrowm merged commit 8b691d4 into strands-agents:main Dec 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants