Further improve formatting of Core#412
Open
keyboardDrummer wants to merge 20 commits intostrata-org:mainfrom
Open
Further improve formatting of Core#412keyboardDrummer wants to merge 20 commits intostrata-org:mainfrom
keyboardDrummer wants to merge 20 commits intostrata-org:mainfrom
Conversation
…mer/Strata into furtherCoreFormattingChange
atomb
approved these changes
Feb 12, 2026
Contributor
atomb
left a comment
There was a problem hiding this comment.
I noted one small suggestion for formatting, but it's not at all blocking.
|
|
||
| -- 13. loop: with measure and invariant | ||
| /-- | ||
| info: while |
Contributor
There was a problem hiding this comment.
It'd be nice to have this closer to source syntax. Maybe:
while ((x : int) == #0)
decreases (x : int)
invariant #true
...
And the decreases and invariant could simply be omitted when they don't exist.
| # SPDX-License-Identifier: Apache-2.0 OR MIT | ||
| #!/usr/bin/env python3 | ||
| """ | ||
| Parse `lake test` output to extract #guard_msgs diffs and apply fixes. |
Contributor
There was a problem hiding this comment.
Thanks for writing this! It'll be a huge help to all of us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Toolsthat enables automatically updating the results of#guard_msgBefore:
After:
Applications in expressions require fewer parenthesis are are shown in a tree like fashion when they do not fit on a line:
Before
After
Testing
Updated tests