Skip to content

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Jan 14, 2026

Related stratis-storage/project#842

Summary by CodeRabbit

  • Chores
    • Updated the Rust toolchain version used in continuous integration workflows to the latest supported version.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran added this to the v3.9.0 milestone Jan 14, 2026
@mulkieran mulkieran self-assigned this Jan 14, 2026
@mulkieran mulkieran moved this to In Review in 2026January Jan 14, 2026
@mulkieran
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

Walkthrough

The PR updates the Rust toolchain version from 1.82.0 to 1.85.0 across GitHub Actions workflow files to establish the new minimum supported Rust version in CI configurations.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Toolchain Updates
.github/workflows/main.yml, .github/workflows/push.yml
Updated Rust toolchain specification from 1.82.0 to 1.85.0 across multiple workflow jobs to reflect the new lowest supported Rust toolchain version

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Increase lowest supported version of Rust to 1.85' is concise, specific, and directly matches the main change—updating the Rust toolchain version from 1.82.0 to 1.85.0 across workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 86a1df0 and dfdbfde.

📒 Files selected for processing (2)
  • .github/workflows/main.yml
  • .github/workflows/push.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: coverage-runs
🔇 Additional comments (3)
.github/workflows/push.yml (1)

22-22: LGTM!

The toolchain version bump to 1.85.0 aligns with the PR objective to raise the minimum supported Rust version. The inline comment clearly documents the intent.

.github/workflows/main.yml (2)

113-113: LGTM!

The toolchain version is correctly updated to 1.85.0 for the test-runs job, consistent with the PR objective and the push.yml workflow.


216-216: LGTM!

The toolchain version is correctly updated to 1.85.0 for the coverage-runs job, maintaining consistency across all jobs that use the "LOWEST SUPPORTED RUST TOOLCHAIN".

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mulkieran mulkieran merged commit 00643ca into stratis-storage:master Jan 14, 2026
9 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 2026January Jan 14, 2026
@mulkieran mulkieran deleted the issue_project_842 branch January 14, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant