-
Notifications
You must be signed in to change notification settings - Fork 256
fix project.license SetuptoolsDeprecationWarning #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix project.license SetuptoolsDeprecationWarning #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the project license configuration to use SPDX-compliant license identifiers and addresses SetuptoolsDeprecationWarning by adopting the modern PEP 621 license field syntax.
- Replaces verbose license names with official SPDX identifiers (e.g., "MIT license" → "MIT", "Apache Software License 2.0" → "Apache-2.0")
- Migrates from deprecated
[project.license]table format to inlinelicensefield withlicense-filesarray - Bumps minimum setuptools requirement from >=61.0 to >=77.0 to ensure compatibility with the new license syntax
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cookiecutter/v2/cookiecutter.json | Updated license options to use SPDX identifiers instead of verbose names |
| templates/v2/template/pyproject.toml | Replaced [project.license] table with inline license = "MIT" and license-files array; bumped setuptools to >=77.0 |
| templates/v2/template-reactless/pyproject.toml | Applied same license syntax modernization and setuptools version bump as template variant |
| .github/replay-files/v2/template.json | Updated replay file to use "MIT" instead of "MIT license" for consistency |
| .github/replay-files/v2/template-reactless.json | Updated replay file to use "MIT" instead of "MIT license" for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
sfc-gh-bnisco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for filing and fixing this. I have 1 suggestion inline, but should be good to go after!
Use SPDX valid license names.
Use
project.license-filesinstead of deprecatedproject.license.file.Bump setuptools requirement to >=77.0.
Fixes #126