Skip to content

Add time parameter to send-time#85

Merged
kbrddestroyer merged 1 commit into
strodgers:mainfrom
rhetenor:add-time-parameter
Mar 31, 2026
Merged

Add time parameter to send-time#85
kbrddestroyer merged 1 commit into
strodgers:mainfrom
rhetenor:add-time-parameter

Conversation

@rhetenor
Copy link
Copy Markdown

Hey,

Wanted to set a custom time for keeping track of projects I'm working on. The infrastructure is there but there was no CLI interface for it, so I quickly hacked it in.

With this send-time now takes an optional time argument which is parsed by dateutil (already part of project dependencies).

Thanks for the project!

@kbrddestroyer kbrddestroyer self-requested a review March 24, 2026 11:25

import tkinter as tk
import dateutil
from dateutil import parser
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not needed since you use dateutil.parser.parse(time)

import tkinter as tk
import dateutil
from dateutil import parser
from functools import wraps
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import should be

from functools import wraps
import dateutil

Copy link
Copy Markdown
Collaborator

@kbrddestroyer kbrddestroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs minor changes to pass codestyle checks

@rhetenor rhetenor force-pushed the add-time-parameter branch from 97ccc73 to e8ec355 Compare March 27, 2026 09:29
@rhetenor
Copy link
Copy Markdown
Author

Only importing dateutil is not enough, it does not import the parser class.
I thought only writing parser.parse(time) is a bit too ambiguous naming, but yeah it obviously creates an unused import. Sorry for not running the tests, it was a bit late at work!

Fixed the unused import by removing it and only calling parser.parse

@kbrddestroyer kbrddestroyer merged commit 2560b6f into strodgers:main Mar 31, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants