Open
Conversation
Owner
|
Cool, thanks for the PR! Will take a bit of time before I can review and merge this, thanks for your patience. net472 was there for Homebrew, which only had mono and no proper net5.0/net6.0 support. Now there's a dotnet formula for Homebrew, so I'll hopefully get it working with net6.0, Homebrew and dotnet. |
Owner
|
Hey, I released v2.11.0 as preparation for the windows support, to remove net472 support and move everything to net6.0. I've also merged your PR into the windows branch and added some fixes and changes. Most notably:
Outstanding issues:
Feel free to update your PR if you have further changes. I also appreciate anyone testing the windows branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Windows support to the project.
Had to remove net472 support and go directly to net6, so I'm not sure if Mac support still works.