Skip to content

Conversation

@nielspardon
Copy link
Member

@nielspardon nielspardon commented Jan 15, 2026

related to substrait-io/substrait#940 and substrait-io/substrait#849

  • updates the substrait submodule to 0.81.0
  • removes core/src/main/java/io/substrait/type/proto/ParameterizedProtoConverter.java which is no longer part of the spec
  • removes core/src/main/java/io/substrait/type/proto/TypeExpressionProtoVisitor.java which is no longer part of the spec

@benbellick
Copy link
Member

benbellick commented Jan 15, 2026

I'm in support of this, but let's wait until the upstream is resolved before merging this IMO.

EDIT: Also, when the upstream settles, we will have to bump the version of substait here, and then this file will become a compilation error :)

@nielspardon
Copy link
Member Author

I'm in support of this, but let's wait until the upstream is resolved before merging this IMO.

EDIT: Also, when the upstream settles, we will have to bump the version of substait here, and then this file will become a compilation error :)

Fine with me. Just found this file in my research to understand whether this is used anywhere and thought I prepare the PR before I forget about it.

@nielspardon
Copy link
Member Author

substrait-io/substrait#940 has been merged

Signed-off-by: Niels Pardon <par@zurich.ibm.com>
@nielspardon nielspardon changed the title chore: remove unused TypeExpressionProtoVisitor chore: update to substrait 0.81.0 Feb 10, 2026
@bestbeforetoday bestbeforetoday merged commit ac4256f into substrait-io:main Feb 11, 2026
14 checks passed
@benbellick
Copy link
Member

Nice, thanks for doing this! I don't know if this is the best place to raise this discussion, but I'm wondering if we should try and make a point moving forwards of opening tickets for all of the relevant upstream substrait changes so that we don't forget to tackle them.

This is not relevant for this PR because

  1. it is already merged, and
  2. the only relevant change is something I have already made a ticket for here

Just making a note for the future! Thanks 🚀

@nielspardon
Copy link
Member Author

I don't know if this is the best place to raise this discussion

I created a thread in the Substrait Slack in #substrait-java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants