Skip to content

⚡ Bolt: [performance improvement] Replace Array.from with for...of in builder#70

Open
subsubl wants to merge 1 commit intomasterfrom
bolt-perf-builder-map-lookup-1509960646220199887
Open

⚡ Bolt: [performance improvement] Replace Array.from with for...of in builder#70
subsubl wants to merge 1 commit intomasterfrom
bolt-perf-builder-map-lookup-1509960646220199887

Conversation

@subsubl
Copy link
Copy Markdown
Owner

@subsubl subsubl commented Mar 21, 2026

💡 What: Replaced the use of Array.from(filesMap.value.entries()).find(...) with for...of loops in validateFiles and packApp inside pages/builder.vue.

🎯 Why: Using Array.from() to convert an entire Map (which could contain hundreds or thousands of files) into an array just to search for a single element is highly inefficient. It triggers an unnecessary O(N) array allocation and adds pressure to the garbage collector.

📊 Impact: This change speeds up the validation and packing steps by completely avoiding the intermediate array allocation. Time complexity of the search is improved since it can early return (break) without converting the entire map first.

🔬 Measurement: Run pnpm build to verify the build completes successfully. Profile the Mini App Packer (/builder) by uploading a large app directory and measuring the heap memory usage during validation and packing.


PR created automatically by Jules for task 1509960646220199887 started by @subsubl

Replaced `Array.from(filesMap.value.entries()).find(...)` with `for...of` loops
in `pages/builder.vue`. This prevents unnecessary O(N) array allocations
and reduces garbage collection pressure when validating folders or packing apps.

Co-authored-by: subsubl <114085822+subsubl@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant