Skip to content

⚡ Bolt: Replace Array.from() with for...of and optimize parsing in pages/builder.vue #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
subsubl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡ Bolt: Replace Array.from() with for...of and optimize parsing in pages/builder.vue #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 35 additions & 11 deletions pages/builder.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,14 @@ const validateFiles = async () => {
} else {
error.value = null;
// Parse appinfo.spixi
const appInfoFile = Array.from(filesMap.value.entries()).find(
([path]) => path.toLowerCase() === 'appinfo.spixi'
)?.[1];
// ⚡ Bolt Optimization: Use for...of loop over map entries instead of Array.from() to prevent O(N) array allocation overhead
let appInfoFile;
for (const [path, file] of filesMap.value.entries()) {
if (path.toLowerCase() === 'appinfo.spixi') {
appInfoFile = file;
break;
}
}

if (appInfoFile) {
const text = await appInfoFile.text();
Expand Down Expand Up @@ -194,14 +199,28 @@ const bytesToNice = (n: number) => {
return `${v.toFixed(v < 10 && i > 0 ? 2 : 0)} ${units[i]}`;
};

// ⚡ Bolt Optimization: Replace regex and .split() with a manual parser loop to avoid O(N) intermediate array generation and garbage collection pressure
const parseAppInfo = (text: string) => {
const lines = text.split(/\r?\n/);
const info: Record<string, string> = {};
for (const line of lines) {
const match = line.match(/^\s*([^=]+?)\s*=\s*(.*?)\s*$/);
if (match) {
info[match[1]] = match[2];
let pos = 0;
const len = text.length;

while (pos < len) {
let end = text.indexOf('\n', pos);
if (end === -1) end = len;

const line = text.substring(pos, end);
const eqIdx = line.indexOf('=');

if (eqIdx !== -1) {
const key = line.substring(0, eqIdx).trim();
if (key) {
const val = line.substring(eqIdx + 1).trim();
info[key] = val;
}
}

pos = end + 1;
}
return info;
};
Expand All @@ -220,9 +239,14 @@ const packApp = async () => {
success.value = false;

try {
const iconFile = Array.from(filesMap.value.entries()).find(
([path]) => path.toLowerCase() === 'icon.png'
)?.[1];
// ⚡ Bolt Optimization: Use for...of loop over map entries instead of Array.from() to prevent O(N) array allocation overhead
let iconFile;
for (const [path, file] of filesMap.value.entries()) {
if (path.toLowerCase() === 'icon.png') {
iconFile = file;
break;
}
}

// Use data from form
const appInfo = appFormData.value;
Expand Down