Skip to content

fix ImageType NotBlank constraint #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilaria-orlando wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix ImageType NotBlank constraint #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Form/Type/ImageType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function (FormEvent $event) use ($options) {
if ($required) {
$fileFieldOptions['constraints'] = [
new NotBlank(
['message' => $options['required_image_error']]
message: $options['required_image_error']

@sourcery-ai sourcery-ai Bot Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Using a named argument here does not match NotBlank's constructor signature and will break at runtime.

NotBlank’s constructor takes an options array as its first (and only) argument, so ['message' => $options['required_image_error']] was correct. Using message: as a named parameter does not match the constructor and will cause a named-parameter runtime error. Please either revert to the array form or change this to new NotBlank(['message' => $options['required_image_error']]) to keep the behavior intact.

),
];
}
Expand Down