Implement client-side of the SCRAM auth#414
Merged
sunng87 merged 2 commits intosunng87:masterfrom Mar 10, 2026
Merged
Conversation
Contributor
Author
|
Is there an example of tests I could follow for testing the integration with the networking code (the |
Owner
|
@Tpt Will check the code this weekend. Unfortunately we don't have integration tests for client APIs for now. |
sunng87
reviewed
Mar 8, 2026
sunng87
reviewed
Mar 8, 2026
sunng87
reviewed
Mar 8, 2026
Contributor
Author
|
@sunng87 Thank you! Review comments applied |
Contributor
Author
|
@sunng87 Thank you for the review! |
Owner
|
@Tpt Thank you! Will think about integration tests for the client APIs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Channel bindings is not done yet