feat(storage): add TUSUploadEngine and UploadMethod smart routing#992
Open
grdsdev wants to merge 2 commits into
Open
feat(storage): add TUSUploadEngine and UploadMethod smart routing#992grdsdev wants to merge 2 commits into
grdsdev wants to merge 2 commits into
Conversation
grdsdev
force-pushed
the
stacked/pr2-tus
branch
2 times, most recently
from
a05b1ee to
72af621
Compare
- Add TUSUploadEngine actor implementing TUS 1.0.0 resumable uploads with 6 MB chunks, pause/resume/cancel, 409 offset re-sync, and cooperative Swift Task cancellation - Add UploadMethod enum (.auto, .multipart, .resumable) as a parameter on upload() and update() - .auto picks multipart for files <= 6 MB and TUS for larger files (configurable via tusChunkSize) - Add tusChunkSize to StorageClientConfiguration Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #991.
TUSUploadEngineactor implementing TUS 1.0.0 resumable uploads with 6 MB chunks, pause/resume/cancel, 409 offset re-sync, and cooperative Swift Task cancellationUploadMethodenum (.auto,.multipart,.resumable) as a parameter onupload()andupdate().autopicks multipart for files ≤ 6 MB and TUS for larger files (configurable viatusChunkSize)API changes
```swift
enum UploadMethod {
case auto // <= 6 MB -> multipart, > 6 MB -> TUS
case multipart // always single HTTP request
case resumable // always TUS; supports pause/resume/cancel
}
func upload(_ path: String, data: Data, options: FileOptions = .init(), method: UploadMethod = .auto) -> StorageUploadTask
```
Test plan
TUSUploadEngineTests— all passStorageFileAPITests— all pass (including method: .multipart and method: .resumable tests)🤖 Generated with Claude Code