Skip to content

array-2 completed#1831

Open
melvinmilkiyas wants to merge 1 commit intosuper30admin:masterfrom
melvinmilkiyas:master
Open

array-2 completed#1831
melvinmilkiyas wants to merge 1 commit intosuper30admin:masterfrom
melvinmilkiyas:master

Conversation

@melvinmilkiyas
Copy link

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • Both solutions demonstrate a good understanding of the problems and implement efficient algorithms.
  • The use of in-place marking and intermediate states shows creative problem-solving.
  • Time and space complexity are well-optimized.

Areas for Improvement:

  • In "find-disapprearing-numbers.py", the variable 'r' could be named more descriptively (e.g., 'index').
  • The indentation in "find-disapprearing-numbers.py" is inconsistent (e.g., the 'arr' initialization is not aligned properly).
  • In "game-of-life.py", the print statement in 'isAlive' might be leftover debug code and should be removed.
  • Consider adding comments to explain the intermediate states (2 and 3) in "game-of-life.py" for better clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants