bug: can't load document with block level permission elements (SD-1840)

[luccas-harbour]

• The w:permStart and w:permEnd tags can show up as block-level nodes but we used to support them only at the inline-level
• New permStartBlock and permEndBlock nodes have been added for this and the permissionRanges plugin has been updated to support them.

[linear]

SD-1840 Bug: can't load document with block level permission elements

[github-actions]

Based on my analysis of the code changes and knowledge of the ECMA-376 specification, I can provide a review:

Status: PASS

The permission range handlers in this PR correctly implement the ECMA-376 specification for w:permStart and w:permEnd elements.

Verification Summary

I've reviewed the OOXML element handlers against my knowledge of ECMA-376 Part 1 (WordprocessingML):

w:permStart (§17.13.7.1)

Attributes implemented:

• w:id (required) - correctly mapped as string
• w:edGrp (optional) - editor group identifier, correctly mapped as string
• w:ed (optional) - editor identifier, correctly mapped as string
• w:colFirst (optional) - first column in table permission range, correctly parsed as integer
• w:colLast (optional) - last column in table permission range, correctly parsed as integer

All 5 attributes match the spec. The w:id attribute is required per spec, though the code treats it as nullable (this is acceptable for error handling).

w:permEnd (§17.13.7.2)

Attributes implemented:

• w:id (required) - correctly mapped as string
• w:displacedByCustomXml (optional) - correctly mapped as string

Both attributes match the spec.

Implementation Notes

The PR correctly:

1. Uses context-aware encoding to differentiate between inline (permStart/permEnd) and block-level (permStartBlock/permEndBlock) permission markers based on their parent elements
2. Preserves all attribute values during round-trip conversion
3. Handles both inline and block contexts as permitted by the spec (permission ranges can appear in both run-level and paragraph-level contexts)
4. Correctly parses integer values for colFirst/colLast using the utility functions

No spec violations detected. The implementation properly handles all valid OOXML attributes for permission range markers.

For complete spec details, see https://ooxml.dev/spec?q=permStart and https://ooxml.dev/spec?q=permEnd.

[caio-pizzol]

Nice one @luccas-harbour!

Added a few comments.

Do you think we need interaction stories on this onw?

[caio-pizzol]

LGTM

[harbournick]

LGTM