Merged
Conversation
- Introduced `DocxTab` and `PdfTab` components for handling DOCX and PDF documents respectively. - Updated `App` component to manage tab switching between DOCX and PDF views. - Enhanced styling for document viewer and controls in `App.css`. - Added `TabHeader` component for better navigation between document types. - Integrated `pdfjs-dist` for PDF rendering capabilities in the demo app. - Updated dependencies in `package.json` and `pnpm-lock.yaml` to include `pdfjs-dist`.
andrii-harbour
changed the title
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Collaborator
|
@artem-harbour mind taking a peek at this one? |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
artem-harbour
requested changes
Feb 20, 2026
Contributor
artem-harbour
left a comment
artem-harbour
left a comment
There was a problem hiding this comment.
Added a minor comments.
Contributor
Author
|
@artem-harbour fixed. Made it explicitly set. |
harbournick
deleted the
andrii/sd-1848-resolve-pdf-loading-issue-in-superdoc-esign-viewer
branch
Contributor
|
🎉 This PR is included in esign v2.1.0-next.7 The release is available on GitHub release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocxTabandPdfTabcomponents for handling DOCX and PDF documents respectively.Appcomponent to manage tab switching between DOCX and PDF views.App.css.TabHeadercomponent for better navigation between document types.pdfjs-distfor PDF rendering capabilities in the demo app.package.jsonandpnpm-lock.yamlto includepdfjs-dist.