- Added ContentWdw,MoveElemetToConcept#242
Conversation
There was a problem hiding this comment.
-
Can you fix the few issues I've outlined ?
-
More globally, there are problems with the coding style (e.g. SMNatives.TContents, ContentsWdw, ...).
The easiest way to address this would be for you to install Resharper. It will load the project's coding style and automatically apply them. You can also run Resharper's "Refactor" function on existing code to reformat it (e.g. TNatives.TContents).
- For the rest, good work !
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SuperMemoAssistant.VersionBuilder", "src\Core\SuperMemoAssistant.VersionBuilder\SuperMemoAssistant.VersionBuilder.csproj", "{712820C7-6A72-4829-8D39-EDE2FDB32666}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SuperMemoAssistant.Plugins.OmniMemo", "src\Plugins\SuperMemoAssistant.Plugins.OmniMemo\src\SuperMemoAssistant.Plugins.OmniMemo\SuperMemoAssistant.Plugins.OmniMemo.csproj", "{F737AECE-9DAB-40EB-A2EF-DE97F43BA87C}" | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SuperMemoAssistant.Plugins.TestSetConceptNo", "..\SuperMemoAssistant.Plugins.TestSetConceptNo\src\SuperMemoAssistant.Plugins.TestSetConceptNo\SuperMemoAssistant.Plugins.TestSetConceptNo.csproj", "{BAC96BE4-668C-477C-B02B-C496147EEC3E}" |
| "ElWdw_ForceRepetitionExt": "55 8B EC 81 C4 ? ? ? ? 88 4D F7 89 55 F8 89 45 FC 8D 4D 81", | ||
| // ???? TElWind::MIForgetClick or TElWind::MIJumpIntervalClick => Last call | ||
| "ElWdw_RestoreLearningMode": "55 8B EC 51 89 45 FC 8B 45 FC 80 B8 ? ? ? ? ? 75 1E" | ||
| "ElWdw_RestoreLearningMode": "55 8B EC 51 89 45 FC 8B 45 FC 80 B8 ? ? ? ? ? 75 1E", |
There was a problem hiding this comment.
There shouldn't be a comma at the end of the line
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SuperMemoAssistant.VersionBuilder", "src\Core\SuperMemoAssistant.VersionBuilder\SuperMemoAssistant.VersionBuilder.csproj", "{712820C7-6A72-4829-8D39-EDE2FDB32666}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SuperMemoAssistant.Plugins.OmniMemo", "src\Plugins\SuperMemoAssistant.Plugins.OmniMemo\src\SuperMemoAssistant.Plugins.OmniMemo\SuperMemoAssistant.Plugins.OmniMemo.csproj", "{F737AECE-9DAB-40EB-A2EF-DE97F43BA87C}" | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SuperMemoAssistant.Plugins.TestSetConceptNo", "..\SuperMemoAssistant.Plugins.TestSetConceptNo\src\SuperMemoAssistant.Plugins.TestSetConceptNo\SuperMemoAssistant.Plugins.TestSetConceptNo.csproj", "{BAC96BE4-668C-477C-B02B-C496147EEC3E}" |
There was a problem hiding this comment.
You'll need to pull the latest version, the OmniMemo plugin is being erased
|
|
||
| if (builder.Concept != null) | ||
| if (Core.SM.UI.ElementWdw.SetCurrentConcept(builder.Concept.Id) == false) | ||
| if (Core.SM.UI.ContentWdw.MoveElementToConcept(this[elemId].Id,builder.Concept.Id) == false) |
There was a problem hiding this comment.
Can you add a space after the comma ?
if (Core.SM.UI.ContentWdw.MoveElementToConcept(this[elemId].Id, builder.Concept.Id)
| public TRegistry Registry { get; } | ||
| public TFileSpace FileSpace { get; } | ||
| public TQueue Queue { get; } | ||
| public TContents Contents { get; } |
There was a problem hiding this comment.
Missing a space for alignment (coding style)
|
|
||
| public ContentWdw() | ||
| { | ||
| Core.SMA.OnSMStartedEvent += OnSMStartedEventAsync; |
There was a problem hiding this comment.
Can you replace with OnSMStarting ?
|
|
||
|
|
||
| #region Methods | ||
| private async Task OnSMStartedEventAsync(object sender, |
There was a problem hiding this comment.
Can you replace with OnSMStarting ?
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PackageReference Update="Nerdbank.GitVersioning" Version="3.2.31" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
I have no clue how but will remove it.
ghost
requested a review
from
alexis-
left a comment
alexis-
left a comment
There was a problem hiding this comment.
All good except the versions.json. When you commit make sure to compare all the files one by one.
I've updated them and I'm accepting the PR thanks !
alexis-
left a comment
alexis-
left a comment
There was a problem hiding this comment.
I actually missed something during my review. The .sln seems a little messed up. At a very quick glance I identified:
- You've added a x64 platform
- Some configurations are missing (NuPack)
2 participants
No description provided.