Skip to content

[WIP]: experimental closure isolation inlay hints#2653

Draft
jamieQ wants to merge 2 commits into
swiftlang:mainfrom
jamieQ:isolation-info
Draft

[WIP]: experimental closure isolation inlay hints#2653
jamieQ wants to merge 2 commits into
swiftlang:mainfrom
jamieQ:isolation-info

Conversation

@jamieQ
Copy link
Copy Markdown

@jamieQ jamieQ commented May 17, 2026

WIP.

depends on: swiftlang/swift#89198

@Steffeeen
Copy link
Copy Markdown
Member

I just quickly looked at this, as I recently changed inlay hint handling in #2597.

The actual SourceKit request should probably be in computeTypeInlayHints() in InlayHintManager.swift. This allows doing both SourceKit requests concurrently. It also ensures that the results are cached to avoid flickering (see the linked PR and corresponding issue for more info).

For running the tests with a local build of SourceKit have a look at the developer docs. They should describe your use case exactly. Feel free to ping me if you have any questions. After moving the SourceKit request to computeTypeInlayHints() you should also be able to reuse the test infrastructure of the other inlay hint tests. The easiest approach is probably to just add the type inlay hints into the asserts instead of trying to filter them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants