You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just quickly looked at this, as I recently changed inlay hint handling in #2597.
The actual SourceKit request should probably be in computeTypeInlayHints() in InlayHintManager.swift. This allows doing both SourceKit requests concurrently. It also ensures that the results are cached to avoid flickering (see the linked PR and corresponding issue for more info).
For running the tests with a local build of SourceKit have a look at the developer docs. They should describe your use case exactly. Feel free to ping me if you have any questions. After moving the SourceKit request to computeTypeInlayHints() you should also be able to reuse the test infrastructure of the other inlay hint tests. The easiest approach is probably to just add the type inlay hints into the asserts instead of trying to filter them out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP.
depends on: swiftlang/swift#89198