Migrate test-case atomic usages to ThreadSafeBox / Atomic#2665
Merged
Conversation
Migrate remaining AtomicBool / AtomicUInt32 usages in test cases to ThreadSafeBox / Atomic. - Closure-captured `AtomicBool` flags become `ThreadSafeBox<Bool>` for now. We will revisit this when eliminating ThreadSafeBox. - One `AtomicUInt32` counter (SourceKitDRegistryTests.swift's `nextToken`) to `Atomic<UInt32>`.
Member
Author
|
swiftlang/swift-tools-protocols#51 |
ahoppen
approved these changes
May 26, 2026
hamishknight
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate remaining
AtomicBool/AtomicUInt32usages in test cases to ThreadSafeBox / Atomic.AtomicBoolflags becomeThreadSafeBox<Bool>for now.We will revisit this when eliminating ThreadSafeBox.
AtomicUInt32counter (SourceKitDRegistryTests.swift'snextToken) toAtomic<UInt32>.