Add missing dependencies in Package.swift and CMakeLists.txt#2674
Open
rintaro wants to merge 1 commit into
Open
Add missing dependencies in Package.swift and CMakeLists.txt#2674rintaro wants to merge 1 commit into
rintaro wants to merge 1 commit into
Conversation
Member
Author
|
@swift-ci Please test |
rintaro
force-pushed
the
add-missing-toolsprotocolsswiftextensions-deps
branch
from
1d58b49 to
0a27c23
Compare
rintaro
changed the title
Member
Author
Member
Author
|
swiftlang/swift-tools-protocols#62 |
rintaro
commented
May 29, 2026
| target_link_libraries(SwiftSourceKitClientPlugin PRIVATE | ||
| Csourcekitd | ||
| SourceKitD | ||
| SourceKitDForPlugin |
Member
Author
There was a problem hiding this comment.
I believe this was just a mistake.
Member
Author
|
swiftlang/swift-tools-protocols#62 |
A number of targets imported modules that weren't declared in their `dependencies` (Package.swift) or `target_link_libraries` (CMakeLists.txt). They built today via transitive resolution, but the dependency is part of each target's import surface and should be declared explicitly.
rintaro
force-pushed
the
add-missing-toolsprotocolsswiftextensions-deps
branch
from
0a27c23 to
22ea87b
Compare
Member
Author
|
swiftlang/swift-tools-protocols#62 |
Member
Author
|
swiftlang/swift-tools-protocols#62 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing target
dependenciesin Package.swift ortarget_link_librariesin CMakeLists.txt