Migrate to swift-tools-protocols's withTimeout family#2678
Draft
rintaro wants to merge 2 commits into
Draft
Conversation
Member
Author
|
swiftlang/swift-tools-protocols#63 |
The `withTimeout` / `withTimeoutResult` implementations now live in swift-tools-protocols. Delete the local copies in `Sources/SwiftExtensions/AsyncUtils.swift`. Also remove the non-throwing `withTaskPriorityChangedHandler` convenience overload in `TaskScheduler.swift`; the upstream version is now `rethrows`, so a non-throwing body works directly. These are visible via the existing `@_spi(SourceKitLSP) import ToolsProtocolsSwiftExtensions`.
rintaro
force-pushed
the
withtimeout-continuation
branch
from
3b94401 to
8c2ee11
Compare
Member
Author
|
swiftlang/swift-tools-protocols#63 |
Member
Author
|
swiftlang/swift-tools-protocols#63 |
Member
Author
|
swiftlang/swift-tools-protocols#63 |
Logs three points to diagnose Linux flakes in testBackgroundIndexingRunsOnSynchronizeRequestEvenIfPaused where update-indexstore never starts after preparation finishes: - when scheduleIndexing reaches the post-preparation withTaskGroup - when updateIndexStore creates a QueuedTask, with priorities - when poke() rejects a pending task because of budget Together these distinguish whether the indexTask body wedged, the QueuedTask was never created, or priority escalation never fired poke() to retry.
Member
Author
|
swiftlang/swift-tools-protocols#63 |
Member
Author
|
swiftlang/swift-tools-protocols#63 |
Member
Author
|
swiftlang/swift-tools-protocols#63 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for swiftlang/swift-tools-protocols#63
Delete
Sources/SwiftExtensions/AsyncUtils.swift; thewithTimeout/withTimeoutResultimplementations now live in swift-tools-protocols.Also remove the non-throwing
withTaskPriorityChangedHandlerconvenience overload. The upstream version is nowrethrows.