Allow passing a pluginConfiguration to SourceKitLSPAPI.BuildDescription#9889
Merged
Conversation
…ion` To stage in swiftlang#9583. Steps: 1. Merge this PR 2. Change SourceKit-LSP to pass a `pluginConfiguration` 3. Merge swiftlang#9583 4. Merge swiftlang/sourcekit-lsp#2446 for a test in SourceKit-LSP
ahoppen
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
dschaefer2
approved these changes
Apr 6, 2026
Member
dschaefer2
left a comment
dschaefer2
left a comment
There was a problem hiding this comment.
Ah, took me a minute to get why you need this to get the smoke tests passing on the other change. :)
Member
|
@swift-ci please test windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To stage in #9583.
Steps:
pluginConfiguration