Fix RegistrationOptions encoding to correctly merge objects#55
Merged
Conversation
The two members of the different `RegistrationOptions` should be encoded into a single object which contains the members of each of the two members.
ahoppen
approved these changes
May 26, 2026
Member
ahoppen
left a comment
There was a problem hiding this comment.
Thanks a lot for noticing and tracking this down 🙏🏽
Member
|
@Steffeeen Could you open a PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two members of the different
RegistrationOptionsshould be encoded into a single object which contains the members of each of the two members. This accidentally broke in 7530abc.By not merging the two objects, the encoding ended up like this:
while it should look like this:
This subsequently lead to the capabilities not being registered on the language server client, which leads to for example semantic tokens not working in VSCode.
The changes in
LSPAny+Coding.swiftare needed to ensure that we don't hit the precondition in thewillset {}ofstorage.