[ASTScopes] Remove ModuleDecl param from findChildContaining
#86093
+20
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer necessary.
hamishknight
requested review from
hborla,
slavapestov and
xedin
as code owners
Contributor
Author
|
@swift-ci please smoke test |
slavapestov
approved these changes
Dec 16, 2025
jamieQ
reviewed
Dec 16, 2025
|
|
||
| protected: | ||
| /// Not const because may reexpand some scopes. | ||
| ASTScopeImpl *findInnermostEnclosingScope(ModuleDecl *, |
Contributor
There was a problem hiding this comment.
out of curiosity (and laziness) – why was it necessary?
Contributor
Author
There was a problem hiding this comment.
It used to use ModuleDecl::getSourceFileContainingLocation to handle different buffer cases, we have since added an API to SourceManager that handles that (#70126)
Contributor
Author
|
@swift-ci please test Windows |
1 similar comment
Contributor
Author
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer necessary.