[CxxInterop] use [[msvc::no_unique_address]] on Windows (NFC) #86098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case used [[no_unique_address]], which is not supported on Windows. Use [[msvc::no_unique_address]] instead. Resolves #86095
hnrklssn
requested review from
Xazax-hun,
egorzhdan,
j-hui and
susmonteiro
as code owners
Member
Author
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Dec 17, 2025
susmonteiro
approved these changes
Dec 17, 2025
egorzhdan
approved these changes
Dec 17, 2025
compnerd
reviewed
Dec 17, 2025
Co-authored-by: Saleem Abdulrasool <compnerd@compnerd.org>
This header is shared by 3 tests, one of which checks diagnostics. If that test picks up an already built module from the module cache, it won't pick up diagnostics in the header. This duplicates the header as two separate modules rather than specifying an explicit module cache, to avoid rebuilding CxxStdlib.
Member
Author
|
@swift-ci please smoke test |
compnerd
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test case uses [[no_unique_address]], which is not supported on Windows. Resolves #86095