Skip to content

Conversation

@sxkm
Copy link
Owner

@sxkm sxkm commented Aug 7, 2020

far. As a reminder, you have: created a branch, created a file and made a commit, and opened a pull request

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pull requests have a body description that tells other contributors about the change you're suggesting, so they understand the context.

Let's edit this pull request to add a body description.

⌨️ Activity: Fixing your pull request

  1. The first comment on your pull request will have the default text of No description provided. Click on the ... icon located at the top right corner of the comment box, then click on Edit to make an edit
  2. Add a description of the changes you've made in the comment box. Feel free to add a description of what you’ve accomplished so far. As a reminder, you have: created a branch, created a file and made a commit, and opened a pull request
  3. Click the green Update comment button at the bottom right of the comment box when done

If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.


I'll respond when I detect this pull request's body has been edited.

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting your file to be named _posts/0000-01-02-1sksm.md.

Let's edit this pull request to fix both of these issues.

⌨️ Activity: Fixing your pull request

  1. Click the Files Changed tab in this pull request
  2. Verify that the only file edited is named _posts/0000-01-02-1sksm.md.
  3. If the file is improperly named, or not in an improper location, click on the pencil icon found on the right side of the screen to edit it.
  4. Above the contents of the file, select all text in the field that contains the filename and delete it.
  5. Continue pressing your backspace key to also delete any directory names that exist.
  6. Type the proper filename:
    _posts/0000-01-02-1sksm.md
  7. Scroll to the bottom and enter a commit message and commit in the Commit Changes section.

If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.


I'll respond below when I detect a commit on this branch.

@sxkm sxkm changed the base branch from master to sxkm-patch-1 August 7, 2020 16:12
Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your base branch should be named master. Let's open a new pull request to fix this.

⌨️ Activity: Adjust PR direction

  1. Click on the Edit button located to the right of your pull request's title
  2. Below the title's comment box, in the "base:" drop-down menu, make sure the “master” branch is selected
  3. A pop-up window will appear asking if you want to change the "base". Click the green Change base button

If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.


I'll respond when I detect this pull request's base has been edited.

Copy link

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your base branch should be named master. Let's open a new pull request to fix this.

⌨️ Activity: Adjust PR direction

  1. Click on the Edit button located to the right of your pull request's title
  2. Below the title's comment box, in the "base:" drop-down menu, make sure the “master” branch is selected
  3. A pop-up window will appear asking if you want to change the "base". Click the green Change base button

If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.


I'll respond when I detect this pull request's base has been edited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants