fix: bump numpy to 1.24.4 in docs/requirements.txt [closes #98]#99
fix: bump numpy to 1.24.4 in docs/requirements.txt [closes #98]#99fyxit-test[bot] wants to merge 1 commit into
Conversation
…y fixes while maintaining compatibility Co-authored-by: syasini <47579697+syasini@users.noreply.github.com>
|
@fyxit why is this build failing? Python package / build (3.6) (pull_request) |
|
The build failure is not caused by the numpy bump — it's a pre-existing CI issue. Root causeThe workflow ( python-version: [3.6, 3.7, 3.8]Python 3.6 and 3.7 are no longer available on GitHub Actions
The 3.8 job was also cancelled because Evidence this is pre-existingThe previous CI run (#45) for PR #97 (which didn't touch numpy at all) also failed with the same error. RecommendationFixing the CI workflow is out of scope for this PR, but it would need a separate change to update the Python matrix to currently supported versions (e.g., |
|
@fyxit sure let's only do 3.11 and 3.12 in a new PR |
|
I attempted to push the CI workflow update but hit a permissions blocker:
The GitHub App I use doesn't have the What the change would look likeYou can apply this manually or grant the - python-version: [3.6, 3.7, 3.8]
+ python-version: ["3.11", "3.12"]
steps:
- - uses: actions/checkout@v2
+ - uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
- uses: actions/setup-python@v2
+ uses: actions/setup-python@v5You'll also need to relax the -healpy==1.13.0
+healpy>=1.13.0I verified that all dependencies in |
Description
Bumps numpy from 1.19.1 to 1.24.4 in
docs/requirements.txt. Version 1.24.4 is the latest numpy 1.x release, which addresses security vulnerabilities while remaining compatible with the project's Python 3.8 requirement and other pinned dependencies. numpy 2.x was not used because it requires Python ≥3.9/3.11 and would conflict with other pinned packages (astropy==4.0.0, scipy==1.3.0, etc.).Resolves #98
Test Plan
Opened collaboratively by syasini and open-swe.