Skip to content

fix: bump numpy to 1.24.4 in docs/requirements.txt [closes #98]#99

Draft
fyxit-test[bot] wants to merge 1 commit into
masterfrom
open-swe/7a1ddac5-9bc9-852c-3e7c-c0d8e15a63cb
Draft

fix: bump numpy to 1.24.4 in docs/requirements.txt [closes #98]#99
fyxit-test[bot] wants to merge 1 commit into
masterfrom
open-swe/7a1ddac5-9bc9-852c-3e7c-c0d8e15a63cb

Conversation

@fyxit-test

@fyxit-test fyxit-test Bot commented Apr 30, 2026

Copy link
Copy Markdown

Description

Bumps numpy from 1.19.1 to 1.24.4 in docs/requirements.txt. Version 1.24.4 is the latest numpy 1.x release, which addresses security vulnerabilities while remaining compatible with the project's Python 3.8 requirement and other pinned dependencies. numpy 2.x was not used because it requires Python ≥3.9/3.11 and would conflict with other pinned packages (astropy==4.0.0, scipy==1.3.0, etc.).

Resolves #98

Test Plan

  • Verify docs build succeeds with the updated numpy version

Opened collaboratively by syasini and open-swe.

…y fixes while maintaining compatibility

Co-authored-by: syasini <47579697+syasini@users.noreply.github.com>
@syasini

syasini commented Apr 30, 2026

Copy link
Copy Markdown
Owner

@fyxit why is this build failing? Python package / build (3.6) (pull_request)

@fyxit-test

fyxit-test Bot commented Apr 30, 2026

Copy link
Copy Markdown
Author

The build failure is not caused by the numpy bump — it's a pre-existing CI issue.

Root cause

The workflow (.github/workflows/python-package.yml) tests against Python 3.6, 3.7, and 3.8:

python-version: [3.6, 3.7, 3.8]

Python 3.6 and 3.7 are no longer available on GitHub Actions ubuntu-latest runners (they were removed when GitHub upgraded to Ubuntu 22.04+). The error is:

Version 3.6 with arch x64 not found

The 3.8 job was also cancelled because fail-fast (the default) aborted the remaining matrix jobs after 3.6 failed.

Evidence this is pre-existing

The previous CI run (#45) for PR #97 (which didn't touch numpy at all) also failed with the same error.

Recommendation

Fixing the CI workflow is out of scope for this PR, but it would need a separate change to update the Python matrix to currently supported versions (e.g., [3.9, 3.10, 3.11, 3.12]) and upgrade the Actions (actions/checkout@v4, actions/setup-python@v5). Happy to open a separate PR for that if you'd like.

@syasini

syasini commented Apr 30, 2026

Copy link
Copy Markdown
Owner

@fyxit sure let's only do 3.11 and 3.12 in a new PR

@fyxit-test

fyxit-test Bot commented Apr 30, 2026

Copy link
Copy Markdown
Author

I attempted to push the CI workflow update but hit a permissions blocker:

refusing to allow a GitHub App to create or update workflow .github/workflows/python-package.yml without workflows permission

The GitHub App I use doesn't have the workflows permission, so I can't modify files under .github/workflows/.

What the change would look like

You can apply this manually or grant the workflows permission to the Fyxit app. Here's the required diff for .github/workflows/python-package.yml:

-        python-version: [3.6, 3.7, 3.8]
+        python-version: ["3.11", "3.12"]

     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v2
+      uses: actions/setup-python@v5

You'll also need to relax the healpy pin in requirements.txt since healpy==1.13.0 doesn't have wheels for Python 3.11+:

-healpy==1.13.0
+healpy>=1.13.0

I verified that all dependencies in requirements.txt resolve cleanly on Python 3.12 with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump numpy from 1.19.1 to 1.22.0 in docs/requirements.txt

2 participants