fix: migration with connection issues #730
Conversation
|
Triggered migration flow against this branch: https://github.com/synonymdev/bitkit-android/actions/runs/21360515728 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jvsena42
changed the title
👆 passed 🟢 Tested manually with internet off (using Network Link Conditioner) as in original issue.
Screen.Recording.2026-01-26.at.15.34.28.mov |
piotr-iohk
left a comment
piotr-iohk
left a comment
There was a problem hiding this comment.
LGTM, tested manually and auto migration tests pass -> #730 (comment)
(modulo claude reported issues 1,2,3 - in case they need to be addressed)
Revert "fix claude detected issues" This reverts commit bf03657. Reapply "fix claude detected issues" This reverts commit 6ae24d4a2bcfead059df6af9024ede219dc08e03.
ben-kaufman
force-pushed
the
fix/migration-with-bad-connection
branch
from
bf03657 to
0037419
Compare
|
Fixed the claude issues |
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
code changes LGTM
relying on Piotr's tests
|
@piotr-iohk can I merge this, do you want to do another testing round?! given…: |
piotr-iohk
left a comment
piotr-iohk
left a comment
There was a problem hiding this comment.
Re-run migration https://github.com/synonymdev/bitkit-android/actions/runs/21363008979
and re-tested ✔️
Fix #697
Testing: install the RN app and create wallet, make txs, add tags, open a channel and turn off the device internet before channel finishes opening (but make sure activity does show on the RN app). Then install the native app (while internet still off) and open it, then turn on the internet and ensure everything migrates correctly once internet is back (and syncing is done).
Also worth testing normal internet scenarios to ensure nothing breaks in regural cases.