feat(send): node connecting UI #401
Open
+248
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwltr
force-pushed
the
feat/node-connecting-ui
branch
from
08d95b0 to
9555fd1
Compare
This comment has been minimized.
This comment has been minimized.
ben-kaufman
reviewed
Jan 26, 2026
Comment on lines
+217
to
+221
| // DEBUG: Add artificial delay to test sync overlay UI | ||
| #if DEBUG | ||
| try? await Task.sleep(nanoseconds: 10_000_000_000) // 5 seconds | ||
| #endif | ||
|
|
Contributor
There was a problem hiding this comment.
Do we still want to leave this?
This reverts commit 0500361.
|
The comment on line 219 of While this is DEBUG-only code for testing the sync overlay UI, the comment should match the implementation to avoid confusion. Suggested fix: Update the comment to say "10 seconds" or change the value to Reference: bitkit-ios/Bitkit/Services/LightningService.swift Lines 217 to 220 in 1a2860f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues/Tasks
Closes #339
Screenshot / Video
Unified invoice:
Simulator.Screen.Recording.-.iPhone.17.-.2026-01-16.at.01.00.09.mov
QuickPay (deeplink):
Simulator.Screen.Recording.-.iPhone.17.-.2026-01-16.at.01.00.09.mov
QA Notes
Use a deeplink like