A number of different changes that were needed for our use of AutoPatch #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wording of comments and error messages - Added comments to highlight the lines of code that form the crux of each migration strategy. - TODO's
…ils if logging is set to DEBUG mode.")
… servlet context (web.xml) - Enhanced JdbcMigrationLauncherFactory.configureFromServletContext() to copy over the migration.strategy property - Clarified the log.info call for which migration strategy is specified. - Added a unit test for MigrationRunnerFactory
…tementsSupported property affects processing. (No functional changes to live code.) - Added coverage of when MultipleStatementsSupported is both true and false. - Added a SQL patch to the test suite that involves a large number of (DDL) statements in a single file. - Added logging calls to show how properties, in general, are being set. - Added logging calls to show how the MultipleStatementsSupported property, specifically, is being set.
…stead. (No code changes required, just POM & imports.)
Author
|
Just wondering if somebody could acknowledge this pull request and give me an indication of when it might be incorporated? I have further changes I would like to make, and I would sure appreciate getting feedback on these changes thus far, first. Thanks. |
Author
|
Still wondering when someone might be available to acknowledge this pull request and see about incorporating it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Sorry about the extraneous reporting of issue #33. I didn't realize that GitHub auto generates a ticket with the pull request.]
The comment on each of my 5 commits should be self-explanatory. Let me know if you have any questions. Feel free to drop out any of the extra logging calls that I added.