pre-commit updates with Ruff

[nriley]

From the Community Backlog session — we are using a combination of pre-commit hooks which are no longer supported, no longer relevant, slow or have newer/better alternatives.

  - repo: https://github.com/pre-commit/mirrors-prettier
    rev: "v4.0.0-alpha.8"
    hooks:
      - id: prettier

this is in use for JavaScript, CSS, JSON, etc. — probably for JSON/YAML/Markdown. The repository above is archived and we should find an alternative. @AndreasArvidsson recommends we give oxc a look.

  - repo: https://github.com/ikamensh/flynt
    rev: "1.0.6"
    hooks:
      - id: flynt

I think we can remove this entirely as it's there to support migration to Python 3.6 string formatting.

  - repo: https://github.com/pycqa/isort
    rev: 8.0.1
    hooks:
      - id: isort
  - repo: https://github.com/psf/black-pre-commit-mirror
    rev: 26.3.1
    hooks:
      - id: black

these two can be replaced by Ruff, as in this PR.

[AndreasArvidsson]

Looks good. Just had one small change I think we need to make.

[nriley]

CI is happy now. I ran into an issue with pre-commit.ci versions which I filed and worked around.

[auscompgeek]

FWIW pre-commit.ci always runs pre-commit run -a so the hook would always run in CI anyway.

[nriley]

Sorry, not sure how that addresses my concern. The issue is if I use types_or: [python, pyproject] to limit the types of files that Ruff evaluates, pre-commit.ci barfs because it does not use a new enough version of identify — see pre-commit-ci/issues#265. I'll try to get a PR submitted today to get this fixed as requested (update: done and merged; I'll try this again next week as not sure how long it takes for the production service to be updated).

[auscompgeek]

If you don't specify this at all ruff would still check (by necessity) the pyproject.toml, wouldn't it?

[AndreasArvidsson]

The Ruff pre commit hook specifies by default types_or: [python, pyi, jupyter] so I don't think so.
https://github.com/astral-sh/ruff-pre-commit/blob/6fec9b7edb08fd9989088709d864a7826dc74e80/.pre-commit-hooks.yaml#L6

[auscompgeek]

The types_or tells pre-commit what files to collect and pass to the hook. But ruff needs to read pyproject.toml since that's how you configure ruff in the first place. So it should report issues with parsing its own config regardless?

Sure, adding it here would mean that a local pre-commit run (or prek run) will rerun ruff if you change the pyproject.toml (without touching any Python files). But that will never be an issue for CI.