Rc/3.0.0#50
Open
martinzigrai wants to merge 25 commits into
Open
Conversation
…uspiciousAppDetectionConfig
tompsota
requested changes
May 18, 2026
| val scopeType = ScopeType.valueOf(getString("scanScope")) | ||
| val trustedInstallSources = optJSONArray("trustedInstallSources") | ||
| ?.toPrimitiveArray<String>()?.toList() | ||
| ?: emptyList() |
Member
There was a problem hiding this comment.
This is not consistent with other platforms, which use null as fallback. Can we do the same here?
| val malwareScanScope = getJSONObject("malwareScanScope").toMalwareScanScope() | ||
| val reasonMode = ReasonMode.valueOf(getString("reasonMode")) | ||
| return SuspiciousAppDetectionConfig( | ||
| if (has("packageNames")) getArraySafe("packageNames").toSet() else null, |
Member
There was a problem hiding this comment.
Empty array results to emptySet(), whereas other platforms result in null. Can you make it consistent pls?
tompsota
requested changes
May 18, 2026
| }; | ||
| }; | ||
|
|
||
| const normalizeConfig = (config: TalsecConfig): TalsecConfig => { |
Member
There was a problem hiding this comment.
The method adds default args. The name does not reflect this properly. Maybe can we name it withDefaults? (applies to all platforms)
tompsota
reviewed
May 18, 2026
Comment on lines
+19
to
+35
| const withSuspiciousAppDetectionDefaults = (config: SuspiciousAppDetectionConfig): SuspiciousAppDetectionConfig => ({ | ||
| ...config, | ||
| malwareScanScope: config.malwareScanScope ?? DEFAULT_MALWARE_SCAN_SCOPE, | ||
| reasonMode: config.reasonMode ?? DEFAULT_REASON_MODE, | ||
| }); | ||
|
|
||
| const normalizeAndroidConfig = (androidConfig: TalsecAndroidConfig): TalsecAndroidConfig => { | ||
| if (!androidConfig.suspiciousAppDetectionConfig) { | ||
| return androidConfig; | ||
| } | ||
| return { | ||
| ...androidConfig, | ||
| suspiciousAppDetectionConfig: withSuspiciousAppDetectionDefaults(androidConfig.suspiciousAppDetectionConfig), | ||
| }; | ||
| }; | ||
|
|
||
| const normalizeConfig = (config: TalsecConfig): TalsecConfig => { |
Member
There was a problem hiding this comment.
These methods should not be part of the API, maybe could we move them to utils? (applies to all platforms)
tompsota
requested changes
May 18, 2026
tompsota
requested changes
May 27, 2026
Rename the `scanScope: ScopeType` field inside the `ScanScope` type to `scopeType` so the field name matches its type name. Update the JSON key, default config, example app, Kotlin native bridge, and dist files accordingly. Co-authored-by: Cursor <cursoragent@cursor.com>
tompsota
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.